imback82 commented on a change in pull request #27642: [SPARK-30885][SQL] V1 table name should be fully qualified if catalog name is provided URL: https://github.com/apache/spark/pull/27642#discussion_r383399234
########## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSessionCatalogSuite.scala ########## @@ -19,13 +19,14 @@ package org.apache.spark.sql.connector import org.apache.spark.sql.{DataFrame, SaveMode} import org.apache.spark.sql.connector.catalog.{Identifier, Table, TableCatalog} +import org.apache.spark.sql.connector.catalog.CatalogManager.SESSION_CATALOG_NAME class DataSourceV2SQLSessionCatalogSuite extends InsertIntoTests(supportsDynamicOverwrite = true, includeSQLOnlyTests = true) with AlterTableTests with SessionCatalogTest[InMemoryTable, InMemoryTableSessionCatalog] { - override protected val catalogAndNamespace = "" + override protected val catalogAndNamespace = "default." Review comment: Yea makes sense. Thanks for pointing this out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org