viirya commented on a change in pull request #27702: [SPARK-30955][SQL] Exclude Generate output when aliasing in nested column pruning URL: https://github.com/apache/spark/pull/27702#discussion_r384946779
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ########## @@ -104,19 +104,23 @@ object NestedColumnAliasing { /** * Return two maps in order to replace nested fields to aliases. * + * If `exclusiveAttrs` is given, any nested field accessors of these attributes + * won't be considered in nested fields aliasing. + * * 1. ExtractValue -> Alias: A new alias is created for each nested field. * 2. ExprId -> Seq[Alias]: A reference attribute has multiple aliases pointing it. */ - def getAliasSubMap(exprList: Seq[Expression]) + def getAliasSubMap(exprList: Seq[Expression], exclusiveAttrs: Seq[Attribute] = Seq.empty) Review comment: I think yes, I will sync #27517 with this later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org