Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4777#discussion_r25485191
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala ---
    @@ -55,6 +60,9 @@ private[spark] class ApplicationPage(parent: MasterWebUI) 
extends WebUIPage("app
         val app = state.activeApps.find(_.id == appId).getOrElse({
           state.completedApps.find(_.id == appId).getOrElse(null)
         })
    +    if (app == null) {
    +      return Seq[Node]()
    --- End diff --
    
    should this return some page with an error message?
    ```
    val content = // some HTML
    UIUtils.basicSparkPage(content, "Application not found")
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to