Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4758#discussion_r25485273
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -315,7 +315,14 @@ abstract class HiveThriftServer2Test extends FunSuite
with BeforeAndAfterAll wit
logInfo(s"Trying to start HiveThriftServer2: port=$port, mode=$mode,
attempt=$attempt")
- logPath = Process(command, None, "SPARK_TESTING" ->
"0").lines.collectFirst {
+ val env = Seq(
+ // Disables SPARK_TESTING to exclude log4j.properties in test
directories.
+ "SPARK_TESTING" -> "0",
+ // Points SPARK_PID_DIR to SPARK_HOME, otherwise only 1 Thrift
server instance can be started
+ // at a time, which is not Jenkins friendly.
+ "SPARK_PID_DIR" -> "../../")
--- End diff --
oh you're right. Looks like we currently set it to `/tmp` already, which is
probably what `java.io.tmpdir` is anyway in most cases
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
