cloud-fan commented on a change in pull request #27752: [SPARK-30999][SQL]
Don't cancel a QueryStageExec which failed before call doMaterialize
URL: https://github.com/apache/spark/pull/27752#discussion_r386381147
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -522,9 +526,11 @@ case class AdaptiveSparkPlanExec(
* Cancel all running stages with best effort and throw an Exception
containing all stage
* materialization errors and stage cancellation errors.
*/
- private def cleanUpAndThrowException(errors: Seq[SparkException]): Unit = {
+ private def cleanUpAndThrowException(
+ errors: Seq[SparkException],
+ skipCancel: Option[Int]): Unit = {
Review comment:
maybe keep the name `earlyFailedStage`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
