cloud-fan commented on a change in pull request #27767: [SPARK-31017][TEST][CORE] Test for shuffle requests packaging with different size and numBlocks limit URL: https://github.com/apache/spark/pull/27767#discussion_r386901142
########## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ########## @@ -254,6 +254,78 @@ class ShuffleBlockFetcherIteratorSuite extends SparkFunSuite with PrivateMethodT intercept[FetchFailedException] { iterator.next() } } + test("SPARK-31017: Hit maxBytesInFlight limitation before maxBlocksInFlightPerAddress") { + val blockManager = mock(classOf[BlockManager]) + val localBmId = BlockManagerId("test-client", "test-local-host", 1) + doReturn(localBmId).when(blockManager).blockManagerId + + val remoteBmId1 = BlockManagerId("test-remote-client-1", "test-remote-host1", 1) + val remoteBmId2 = BlockManagerId("test-remote-client-2", "test-remote-host2", 2) + val remoteBmId3 = BlockManagerId("test-remote-client-3", "test-remote-host2", 3) + // set maxBlocksInFlightPerAddress to Int.MaxValue, Review comment: seems we don't need this line, as we have it in https://github.com/apache/spark/pull/27767/files#diff-d9abbfedd9c2b0aed76c94c91ec0cec2R283 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org