Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4809#discussion_r25542387
  
    --- Diff: python/pyspark/sql.py ---
    @@ -298,11 +294,11 @@ def __init__(self, keyType, valueType, 
valueContainsNull=True):
             :param valueContainsNull: indicates whether values contains
             null values.
     
    -        >>> (MapType(StringType, IntegerType)
    -        ...        == MapType(StringType, IntegerType, True))
    +        >>> (MapType(StringType(), IntegerType())
    +        ...        == MapType(StringType(), IntegerType(), True))
             True
    -        >>> (MapType(StringType, IntegerType, False)
    -        ...        == MapType(StringType, FloatType))
    +        >>> (MapType(StringType(), IntegerType(), False)
    +        ...        == MapType(StringType(), FloatType()))
             False
             """
    --- End diff --
    
    Because we can not cherry-pick the patch from master, I need to re-do all 
the things on 1.2/1.1, so I'd like to keep the changes minimized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to