dbtsai commented on a change in pull request #27728:
[SPARK-17636][SQL][test-hive1.2] Nested Column Predicate Pushdown for Parquet
URL: https://github.com/apache/spark/pull/27728#discussion_r387245545
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
##########
@@ -63,13 +63,38 @@ private[sql] trait ParquetTest extends
FileBasedDataSourceTest {
(f: String => Unit): Unit = withDataSourceFile(data)(f)
/**
- * Writes `data` to a Parquet file and reads it back as a [[DataFrame]],
+ * Writes `data` objects to a Parquet file and reads it back as a
[[DataFrame]],
* which is then passed to `f`. The Parquet file will be deleted after `f`
returns.
*/
- protected def withParquetDataFrame[T <: Product: ClassTag: TypeTag]
+ protected def withParquetDFfromObjs[T <: Product: ClassTag: TypeTag]
(data: Seq[T], testVectorized: Boolean = true)
(f: DataFrame => Unit): Unit = withDataSourceDataFrame(data,
testVectorized)(f)
+ /**
+ * Writes `df` dataframe to a Parquet file and reads it back as a
[[DataFrame]],
+ * which is then passed to `f`. The Parquet file will be deleted after `f`
returns.
+ */
+ protected def withParquetDFfromDF[T <: Product: ClassTag: TypeTag]
+ (df: DataFrame, testVectorized: Boolean = true)
+ (f: DataFrame => Unit): Unit = {
+ withTempPath { file =>
+ df.write.format(dataSourceName).save(file.getCanonicalPath)
+ readFile(file.getCanonicalPath, testVectorized)(f)
+ }
+ }
+
+ /**
+ * Writes `df` to a Parquet file and reads it back as a [[DataFrame]],
+ * which is then passed to `f`. The Parquet file will be deleted after `f`
returns.
+ */
+ protected def toParquetDataFrame(df: DataFrame, testVectorized: Boolean =
true)
Review comment:
They are used in couple places. I can submit another PR for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
