HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387447685
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
I see. what about doing it as:
```scala
case expressions.Contains(e: Expression, Literal(v: UTF8String,
StringType))
if PushDownCol.unapply(name).isDefined =>
e.dataType ...
name ...
```
I faced similar problem before and worked around as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
