Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show 
assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387510949
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, 
isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, 
sc._resources)
 
 Review comment:
   `sc._resources` is for `driver` rather than `executor`? 
   
   I know that `driver` and `executor` are in the same JVM in this case, but we 
also have separate resource configurations for `executor.` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to