gaborgsomogyi edited a comment on issue #27789: [SPARK-30541][TEST] testRetry flaky KafkaDelegationTokenSuite URL: https://github.com/apache/spark/pull/27789#issuecomment-594524053 I'm not against the approach but I've couple of questions before we go on: * Could you reproduce it somehow on your local environment (or any environment where not all the tests run to spare time)? I've tried it to run it for weeks but it has never failed. I would like to understand what causes the issue but since I was not able to find any code glitch + not able to reproduce it's hard. * Which part of the test failed exactly? I'm asking it because at least 2 parts can fail: `beforeAll` and the test itself. I think this won't solve SPARK-30541 since it's failing in the `beforeAll`... * Have you checked this code? ``` /** * Note: this method doesn't support `BeforeAndAfter`. You must use `BeforeAndAfterEach` to * set up and tear down resources. */ def testRetry(s: String, n: Int = 2)(body: => Unit): Unit = { ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
