maryannxue commented on a change in pull request #27793: [SPARK-31037][SQL]
refine AQE config names
URL: https://github.com/apache/spark/pull/27793#discussion_r387806656
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -388,99 +397,98 @@ object SQLConf {
.internal()
.doc("Adaptive query execution is skipped when the query does not have
exchanges or " +
"sub-queries. By setting this config to true (together with " +
- s"'${ADAPTIVE_EXECUTION_ENABLED.key}' enabled), Spark will force apply
adaptive query " +
+ s"'${ADAPTIVE_EXECUTION_ENABLED.key}' set to true), Spark will force
apply adaptive query " +
"execution for all supported queries.")
.version("3.0.0")
.booleanConf
.createWithDefault(false)
- val REDUCE_POST_SHUFFLE_PARTITIONS_ENABLED =
- buildConf("spark.sql.adaptive.shuffle.reducePostShufflePartitions")
- .doc(s"When true and '${ADAPTIVE_EXECUTION_ENABLED.key}' is enabled,
this enables reducing " +
- "the number of post-shuffle partitions based on map output
statistics.")
+ val ADVISORY_SHUFFLE_PARTITION_SIZE_IN_BYTES =
+ buildConf("spark.sql.adaptive.advisoryShufflePartitionSizeInBytes")
+ .doc("The advisory size in bytes of the shuffle partition during
adaptive optimization. " +
+ "It takes effect when Spark coalesces small shuffle partitions or
splits skewed shuffle " +
+ "partition.")
.version("3.0.0")
- .booleanConf
- .createWithDefault(true)
+ .fallbackConf(SHUFFLE_TARGET_POSTSHUFFLE_INPUT_SIZE)
- val FETCH_SHUFFLE_BLOCKS_IN_BATCH_ENABLED =
- buildConf("spark.sql.adaptive.shuffle.fetchShuffleBlocksInBatch")
- .doc("Whether to fetch the continuous shuffle blocks in batch. Instead
of fetching blocks " +
- "one by one, fetching continuous shuffle blocks for the same map task
in batch can " +
- "reduce IO and improve performance. Note, multiple continuous blocks
exist in single " +
- s"fetch request only happen when '${ADAPTIVE_EXECUTION_ENABLED.key}'
and " +
- s"'${REDUCE_POST_SHUFFLE_PARTITIONS_ENABLED.key}' is enabled, this
feature also depends " +
- "on a relocatable serializer, the concatenation support codec in use
and the new version " +
- "shuffle fetch protocol.")
+ val COALESCE_SHUFFLE_PARTITIONS_ENABLED =
+ buildConf("spark.sql.adaptive.coalesceShufflePartitions.enabled")
Review comment:
I'm fine with "coalescePartitions".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
