cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r387816365
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1654,6 +1660,8 @@ object SQLConf {
.doc("""The ID of session local timezone, e.g. "GMT",
"America/Los_Angeles", etc.""")
.version("")
.stringConf
+ .checkValue(isValidTimezone, "The time zone should obey rules managed
by" +
+ " java.time.zone.ZoneRulesProvider")
Review comment:
This is still unclear, maybe just say: `Cannot resolve the give timezone
with ZoneId.of(_, ZoneId.SHORT_IDS)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
