maropu commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone URL: https://github.com/apache/spark/pull/27792#discussion_r388016145
########## File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ########## @@ -348,4 +348,22 @@ class SQLConfSuite extends QueryTest with SharedSparkSession { } check(config2) } + + test("spark.sql.session.timeZone should only accept valid zone id") { + spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "MIT") + assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) === "MIT") + spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "America/Chicago") + assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) === + "America/Chicago") + + intercept[IllegalArgumentException] { + spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "pst") + } + intercept[IllegalArgumentException] { + spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "GMT+8:00") + } + intercept[IllegalArgumentException] { + spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "Asia/shanghai") Review comment: Please check the error messages here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org