cloud-fan commented on a change in pull request #27804: [SPARK-31020][SPARK-31023][SPARK-31025][SPARK-31044][SQL] Support foldable args by `from_csv/json` and `schema_of_csv/json` URL: https://github.com/apache/spark/pull/27804#discussion_r388260818
########## File path: sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out ########## @@ -24,7 +24,7 @@ select from_csv('1', 1) struct<> -- !query output org.apache.spark.sql.AnalysisException -Schema should be specified in DDL format as a string literal or output of the schema_of_csv function instead of 1;; line 1 pos 7 +The expression '1' must be evaluated to a valid string.;; line 1 pos 7 Review comment: and as an error message, seems better to have `The expression '1' is not a valid schema string.` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org