Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4826#discussion_r25561465
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/modelSaveLoad.scala ---
@@ -110,7 +110,7 @@ private[mllib] object Loader {
assert(loadedFields.contains(field.name), s"Unable to parse model
data." +
s" Expected field with name ${field.name} was missing in loaded
schema:" +
s" ${loadedFields.mkString(", ")}")
- assert(loadedFields(field.name) == field.dataType,
+ assert(DataType.equalsIgnoreNullability(loadedFields(field.name),
field.dataType),
--- End diff --
@mengxr Is it OK to ignore the nullability of ArrayType (containsNull
field) and MapType (valueContainsNull field) in this check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
