huaxingao commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs URL: https://github.com/apache/spark/pull/27818#discussion_r389185917
########## File path: mllib/src/main/scala/org/apache/spark/ml/classification/FMClassifier.scala ########## @@ -186,7 +186,7 @@ class FMClassifier @Since("3.0.0") ( @Since("3.0.0") def setSeed(value: Long): this.type = set(seed, value) - override protected[spark] def train( + override protected def train( Review comment: The super class has ```protected def train(dataset: Dataset[_])```. When overriding this, I thought it's not supposed to widen the scope? The other classifiers have ```override protected def train``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org