SaurabhChawla100 commented on a change in pull request #27636:
[SPARK-30873][CORE][YARN]Handling Node Decommissioning for Yarn cluster manger
in Spark
URL: https://github.com/apache/spark/pull/27636#discussion_r390263904
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1525,10 +1539,25 @@ private[spark] class DAGScheduler(
s" ${task.stageAttemptId} and there is a more recent attempt for
that stage " +
s"(attempt ${failedStage.latestInfo.attemptNumber}) running")
} else {
+ if
(!event.reason.asInstanceOf[FetchFailed].countTowardsStageFailures) {
Review comment:
countTowardsStageFailures is introduced as the part of this PR - So this is
for the decommission nodes only. Below is the code where we are setting the
value countTowardsStageFailures=false
```
// Do account fetch failure exception raised by decommissioned
// node against stage failure. Here the logic is to specify,
// if the task failed due to fetchFailed of decommission nodes than
// don't count towards the stageFailure. countTowardsStageFailures
// variable of TaskEndReason, that can be used in DAG scheduler to
account
// fetch failure while checking the stage abort
decommissionTracker match {
case Some(decommissionTracker) =>
if
(decommissionTracker.isNodeDecommissioned(fetchFailed.bmAddress.host)) {
logInfo(s"Do not count fetch failure from decommissioned" +
s" node ${fetchFailed.bmAddress.host}")
fetchFailed.countTowardsStageFailures = false
}
case _ =>
// No action
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
