Github user aborsu985 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4504#discussion_r25652664
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Tokenizer.scala 
---
    @@ -39,3 +39,66 @@ class Tokenizer extends UnaryTransformer[String, 
Seq[String], Tokenizer] {
     
       override protected def outputDataType: DataType = new 
ArrayType(StringType, false)
     }
    +
    +
    +/**
    + * :: AlphaComponent ::
    + * A regex based tokenizer that extracts tokens using a regex.
    + * Optional additional parameters include enabling lowercase 
stabdarization, a minimum character
    + * size for tokens as well as an array of stop words to remove from the 
results.
    + */
    +@AlphaComponent
    +class RegexTokenizer extends UnaryTransformer[String, Seq[String], 
RegexTokenizer] {
    +
    +  val lowerCase = new BooleanParam(this, 
    +      "lowerCase", 
    +      "enable case folding to lower case", 
    +      Some(true))
    +  def setLowercase(value: Boolean) = set(lowerCase, value)
    +  def getLowercase: Boolean = get(lowerCase)
    +
    +  val minLength = new IntParam(this, 
    --- End diff --
    
    I removed excluded as it is indeed unusual and set the default value to 1 
which is standard


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to