nchammas commented on a change in pull request #27912: [SPARK-31155] Enable pydocstyle tests URL: https://github.com/apache/spark/pull/27912#discussion_r392620708
########## File path: dev/requirements.txt ########## @@ -1,5 +1,8 @@ -flake8==3.5.0 +pycodestyle==2.5.0 Review comment: By the way @HyukjinKwon, following on from the discussion here https://github.com/apache/spark/pull/27534#discussion_r377394628, this is a good example of why it's good to pin versions of build/test dependencies. This release of pycodestyle adds new checks that we did not ignore in our `tox.ini` config. So if this had been running without a pinned version, one day our build would have start failing because pycodestyle made a new release with new checks and our build automatically started using it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
