HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions URL: https://github.com/apache/spark/pull/27901#discussion_r392641318
########## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out ########## @@ -4654,111 +4654,111 @@ struct<id:bigint> -- !query select ln(1.2345678e-28) -- !query schema -struct<LOG(1.2345678E-28):double> +struct<log(1.2345678E-28):double> Review comment: I actually realised that there are some more instances such as `ToDegrees`, `ToRadians`, `UnaryMinus` and `UnaryPositive`.. let me exclude these to make the scope my PR addresses smaller ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
