HyukjinKwon commented on a change in pull request #27912: [SPARK-31155] Enable pydocstyle tests URL: https://github.com/apache/spark/pull/27912#discussion_r392638387
########## File path: dev/requirements.txt ########## @@ -1,5 +1,8 @@ -flake8==3.5.0 +pycodestyle==2.5.0 Review comment: On the other hand, not pinning will trigger us to fix quickly to support latest versions. Pinning version will force developers to install different versions of libraries they already have. If something is found we can't easily fix, we could pin the version. If I am not completely wrong, using the latest version by default is the conventional approach in Python side (and R side - it reminds me of [`testthat` case](https://github.com/apache/spark/pull/27359)). This is the approach used in [pandas as an example](https://github.com/pandas-dev/pandas/blob/master/requirements-dev.txt). [I used this approach too](https://github.com/databricks/koalas/blob/master/requirements-dev.txt). I agree, in a way, it can make more sense to pin the version in particular when this is used for CI purpose or release docker image which are supposed to discard of after using once; however, I don't quite agree when this affects other developers' environments. cc @dongjoon-hyun. IIRC, I think we have related discussions at https://github.com/apache/spark/pull/26824. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
