cloud-fan commented on a change in pull request #27915: [WIP][SPARK-31159][SQL]
Rebase date/timestamp from/to Julian calendar in parquet
URL: https://github.com/apache/spark/pull/27915#discussion_r393159478
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -148,7 +148,9 @@ object DateTimeUtils {
def fromJulianDay(day: Int, nanoseconds: Long): SQLTimestamp = {
// use Long to avoid rounding errors
val seconds = (day - JULIAN_DAY_OF_EPOCH).toLong * SECONDS_PER_DAY
- SECONDS.toMicros(seconds) + NANOSECONDS.toMicros(nanoseconds)
+ val micros = SECONDS.toMicros(seconds) + NANOSECONDS.toMicros(nanoseconds)
+ val rebased = rebaseJulianToGregorianMicros(micros)
Review comment:
LGTM. INT96 is a legacy timestamp type in parquet and I'm not surprised if
it follows the java 7 semantic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
