yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL] Parsing seconds fraction with variable length for timestamp URL: https://github.com/apache/spark/pull/27906#discussion_r393214830
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ########## @@ -46,7 +46,8 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper { val jstId = Option(TimeZoneJST.getID) def toMillis(timestamp: String): Long = { - val tf = TimestampFormatter("yyyy-MM-dd HH:mm:ss", ZoneOffset.UTC) + val tf = TimestampFormatter( + "yyyy-MM-dd HH:mm:ss", ZoneOffset.UTC, needVarLengthSecondFraction = false) Review comment: I changed the most used `apply` with default `needVarLengthSecondFraction` as false ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org