cloud-fan commented on a change in pull request #27962: [SPARK-31195][SQL]
Reuse days rebase functions of `DateTimeUtils` in `DaysWritable`
URL: https://github.com/apache/spark/pull/27962#discussion_r395460338
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/DaysWritable.scala
##########
@@ -82,31 +80,15 @@ private[hive] object DaysWritable {
// The code below converts -141714 to -141704.
def rebaseGregorianToJulianDays(daysSinceEpoch: Int): Int = {
if (daysSinceEpoch < DateTimeUtils.GREGORIAN_CUTOVER_DAY) {
Review comment:
shall we always rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
