nchammas commented on a change in pull request #27928: [SPARK-31167][BUILD] Refactor how we track Python test/build dependencies URL: https://github.com/apache/spark/pull/27928#discussion_r395852390
########## File path: dev/requirements.txt ########## @@ -1,5 +1,7 @@ -flake8==3.5.0 +pycodestyle==2.5.0 +flake8==3.7.9 jira==1.0.3 PyGithub==1.26.0 Unidecode==0.04.19 -sphinx +sphinx==2.3.1 +numpy==1.18.1 Review comment: Hmm, on second thought, perhaps the README should be left to a separate PR. We already have advice on setting up a development environment in at least a couple of places, like [Useful Developer Tools](http://spark.apache.org/developer-tools.html) and [`docs/README.md`](https://github.com/apache/spark/blob/fae981e5f32e0ddb86591a616829423dfafb4ed0/docs/README.md#using-rbenv-and-pyenv). Perhaps we should consolidate that advice over on the Useful Developer Tools page, since it fits in with the information already there. Either that, or let's agree on some other approach to take. But I think we can defer any dev documentation changes to a follow-up PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
