Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4899#discussion_r25885193
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/LDAExample.scala ---
@@ -174,7 +174,7 @@ object LDAExample {
// Get dataset of document texts
// One document per line in each text file.
- val textRDD: RDD[String] = sc.textFile(paths.mkString(","))
+ val textRDD: RDD[String] =
sc.textFile(paths.mkString(",")).coalesce(sc.defaultParallelism)
--- End diff --
I agree; this is a basic example. I like the idea of adding a note telling
users they could coalesce if they run this on small documents in practice, but
I don't think we should complicate the code too much.
With one document per text file, the files could be pretty big; it just
depends on document size.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
