Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4688#discussion_r25911695
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -122,6 +126,14 @@ class SparkHadoopUtil extends Logging {
}
/**
+ * Schedule a login from the keytab and principal set using the
--principal and --keytab
+ * arguments to spark-submit. This login happens only when the
credentials of the current user
+ * are about to expire. This method reads SPARK_PRINCIPAL and
SPARK_KEYTAB from the environment
+ * to do the login. This method is a no-op in non-YARN mode.
+ */
+ private[spark] def scheduleLoginFromKeytab(): Unit = {}
--- End diff --
Do you need this method in this class? Seems like it's only ever useful if
you're using `YarnSparkHadoopUtil`, so might be better to just declare it there.
The scaladoc also doesn't match this implementation, but the actual
implementation in the other class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
