Eric5553 commented on a change in pull request #27897: [SPARK-31113][SQL] Add 
SHOW VIEWS command
URL: https://github.com/apache/spark/pull/27897#discussion_r397975602
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
 ##########
 @@ -530,6 +523,16 @@ class ResolveSessionCatalog(
         replace,
         viewType)
 
+    case ShowViewsStatement(SessionCatalogAndNamespace(_, ns), pattern) =>
 
 Review comment:
   Actually, I'm not quite sure about the question. The `SHOW VIEWS` will 
resolve to V1 SessionCatalog which supports `listViews` I think. Do you mean a 
custom catalog implements `TableCatalog`(does not support view related 
commands) will got error? I'll keep learning the `CatalogPlugIn` related code, 
any suggestions would be helpful to me, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to