maryannxue commented on a change in pull request #28022: [SPARK-31253][SQL] Add
metrics to AQE shuffle reader
URL: https://github.com/apache/spark/pull/28022#discussion_r398689742
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -317,43 +317,11 @@ private object ShuffleStage {
private def getMapStats(stage: ShuffleQueryStageExec): MapOutputStatistics =
{
assert(stage.resultOption.isDefined, "ShuffleQueryStageExec should" +
" already be ready when executing OptimizeSkewedPartitions rule")
- stage.resultOption.get.asInstanceOf[MapOutputStatistics]
+ stage.mapStats
Review comment:
You already have assert in `QueryStage.mapStats`. This method can be removed
now. Although I'd prefer the other way around: not define `mapStats` in
`QueryStage` but instead leave the logic in the callers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
