cloud-fan commented on a change in pull request #28033:
[SPARK-31277][SQL][TESTS] Migrate `DateTimeTestUtils` from `TimeZone` to
`ZoneId`
URL: https://github.com/apache/spark/pull/28033#discussion_r399003676
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeTestUtils.scala
##########
@@ -39,7 +41,7 @@ object DateTimeTestUtils {
val UTC_OPT = Option("UTC")
- val ALL_TIMEZONES: Seq[TimeZone] =
TimeZone.getAvailableIDs.toSeq.map(TimeZone.getTimeZone)
+ val ALL_TIMEZONES: Seq[ZoneId] =
ZoneId.getAvailableZoneIds.asScala.map(getZoneId).toSeq
Review comment:
I'm wondering if we should only test the `outstandingZoneIds` instead of
`ALL_TIMEZONES`. The test can be very slow if we test all timezones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
