HeartSaVioR commented on a change in pull request #28040: [SPARK-31278][SS] Fix StreamingQuery output rows metric URL: https://github.com/apache/spark/pull/28040#discussion_r399094221
########## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala ########## @@ -253,9 +253,11 @@ abstract class FileStreamSinkSuite extends StreamTest { addTimestamp(104, 123) // watermark = 90 before this, watermark = 123 - 10 = 113 after this check((100L, 105L) -> 2L) // no-data-batch emits results on 100-105, + assert(query.lastProgress.sink.numOutputRows === 1) Review comment: The last progress here is for "no data & no run" because of the reason I commented earlier - that's why the test fails. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org