Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/4805#discussion_r26012160
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
---
@@ -158,4 +166,37 @@ class DirectKafkaInputDStream[
}
}
+ private[streaming]
+ class DirectKafkaStreamingListener extends StreamingListener {
+
+ val offsetCommitEnabled =
context.conf.getBoolean("spark.streaming.kafka.offsetCommit", false)
--- End diff --
It's more that it needs a clearer name. Definitely don't think it should
be on by default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
