Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4938#discussion_r26034375
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -107,24 +110,28 @@ private[sql] class GenericColumnAccessor(buffer:
ByteBuffer)
with NullableColumnAccessor
private[sql] object ColumnAccessor {
- def apply(buffer: ByteBuffer): ColumnAccessor = {
+ def apply(dataType: DataType, buffer: ByteBuffer): ColumnAccessor = {
val dup = buffer.duplicate().order(ByteOrder.nativeOrder)
- // The first 4 bytes in the buffer indicate the column type.
- val columnTypeId = dup.getInt()
-
- columnTypeId match {
- case INT.typeId => new IntColumnAccessor(dup)
- case LONG.typeId => new LongColumnAccessor(dup)
- case FLOAT.typeId => new FloatColumnAccessor(dup)
- case DOUBLE.typeId => new DoubleColumnAccessor(dup)
- case BOOLEAN.typeId => new BooleanColumnAccessor(dup)
- case BYTE.typeId => new ByteColumnAccessor(dup)
- case SHORT.typeId => new ShortColumnAccessor(dup)
- case STRING.typeId => new StringColumnAccessor(dup)
- case DATE.typeId => new DateColumnAccessor(dup)
- case TIMESTAMP.typeId => new TimestampColumnAccessor(dup)
- case BINARY.typeId => new BinaryColumnAccessor(dup)
- case GENERIC.typeId => new GenericColumnAccessor(dup)
+
+ // The first 4 bytes in the buffer indicate the column type. This
field is not used now,
+ // because we always know the data type of the column ahead of time.
+ dup.getInt()
--- End diff --
However, we can remove this line after removing the whole column type ID
stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
