Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4926#discussion_r26041674
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -179,7 +179,12 @@ private[hive] case class HiveGenericUdf(funcWrapper:
HiveFunctionWrapper, childr
})
i += 1
}
- unwrap(function.evaluate(deferedObjects), returnInspector)
+
+ if (function.getUdfName().endsWith("UDFCurrentDB")) {
--- End diff --
Can you explain why you think returning a `null` is more reasonable than
executing the `UDFCurrentDB`? Seems it will not throws exception anymore in
Hive 0.14:
http://grepcode.com/file/repo1.maven.org/maven2/org.apache.hive/hive-exec/0.14.0/org/apache/hadoop/hive/ql/udf/generic/UDFCurrentDB.java/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
