HyukjinKwon commented on a change in pull request #28089:
[SPARK-30921][PySpark] Predicates on python udf should not be pushdown through
Aggregate
URL: https://github.com/apache/spark/pull/28089#discussion_r402845145
##########
File path: python/pyspark/sql/tests/test_pandas_udf_grouped_agg.py
##########
@@ -491,6 +491,28 @@ def max_udf(v):
agg2 = self.spark.sql("select max_udf(id) from table")
assert_frame_equal(agg1.toPandas(), agg2.toPandas())
+ def test_no_predicate_pushdown_through(self):
+ from pyspark.sql.functions import monotonically_increasing_id,
explode_outer
Review comment:
@viirya, I think we should better leave a comment like:
```
def test_case(self):
# SPARK-12345: a short description of the test
...
```
per the new guide written recently
(https://spark.apache.org/contributing.html)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
