Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/3916#issuecomment-77954145
Sorry to spam the PR with comments about Bash word splitting, @vanzin. I
think what you have Bash-wise looks good, but as a matter of consistency I just
went through and marked the places where Bash word splitting bugs are
theoretically possible.
As a habit, I think we should always quote Bash output (whether of
variables, subshell, etc.), though I can see if in some cases you feel it would
be unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
