dongjoon-hyun commented on a change in pull request #28142:
[SPARK-25102][SQL][2.4] Write Spark version to ORC/Parquet file metadata
URL: https://github.com/apache/spark/pull/28142#discussion_r404543692
##########
File path: core/src/main/scala/org/apache/spark/util/VersionUtils.scala
##########
@@ -36,6 +37,19 @@ private[spark] object VersionUtils {
*/
def minorVersion(sparkVersion: String): Int =
majorMinorVersion(sparkVersion)._2
+ /**
+ * Given a Spark version string, return the short version string.
+ * E.g., for 3.0.0-SNAPSHOT, return '3.0.0'.
Review comment:
I didn't change this example in order to minimize the diff between
`branch-2.4` and `master`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
