dongjoon-hyun commented on a change in pull request #27364: [SPARK-31394][K8S] Adds support for Kubernetes NFS volume mounts URL: https://github.com/apache/spark/pull/27364#discussion_r406611010
########## File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesVolumeUtilsSuite.scala ########## @@ -117,4 +117,61 @@ class KubernetesVolumeUtilsSuite extends SparkFunSuite { } assert(e.getMessage.contains("hostPath.volumeName.options.path")) } + + test("Parses nfs volumes correctly") { + val sparkConf = new SparkConf(false) + sparkConf.set("test.nfs.volumeName.mount.path", "/path") + sparkConf.set("test.nfs.volumeName.mount.readOnly", "true") + sparkConf.set("test.nfs.volumeName.options.path", "/share") + sparkConf.set("test.nfs.volumeName.options.server", "nfs.example.com") + + val volumeSpec = KubernetesVolumeUtils.parseVolumesWithPrefix(sparkConf, "test.").head + assert(volumeSpec.volumeName === "volumeName") + assert(volumeSpec.mountPath === "/path") + assert(volumeSpec.mountReadOnly === true) + assert(volumeSpec.volumeConf.asInstanceOf[KubernetesNFSVolumeConf] === + KubernetesNFSVolumeConf("/share", None, "nfs.example.com")) + } + + test("Parses read/write nfs volumes correctly") { + val sparkConf = new SparkConf(false) + sparkConf.set("test.nfs.volumeName.mount.path", "/path") + sparkConf.set("test.nfs.volumeName.mount.readOnly", "false") + sparkConf.set("test.nfs.volumeName.options.path", "/share") + sparkConf.set("test.nfs.volumeName.options.readOnly", "false") + sparkConf.set("test.nfs.volumeName.options.server", "nfs.example.com") + + val volumeSpec = KubernetesVolumeUtils.parseVolumesWithPrefix(sparkConf, "test.").head + assert(volumeSpec.volumeName === "volumeName") + assert(volumeSpec.mountPath === "/path") + assert(volumeSpec.mountReadOnly === false) + assert(volumeSpec.volumeConf.asInstanceOf[KubernetesNFSVolumeConf] === + KubernetesNFSVolumeConf("/share", Some(false), "nfs.example.com")) + } + + test("Fails on missing path option") { + val sparkConf = new SparkConf(false) + sparkConf.set("test.nfs.volumeName.mount.path", "/path") + sparkConf.set("test.nfs.volumeName.mount.readOnly", "true") + sparkConf.set("test.nfs.volumeName.options.pth", "/share") Review comment: Shall we remove this line instead of using `pth`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org