turboFei edited a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task URL: https://github.com/apache/spark/pull/26339#issuecomment-616061133 I just tried to add test for rename failed and task aborted cases. It seems that, if an exception thrown or task aborted when renaming dynamicStagingFiles. The job would abort. Is it still necessary to add tests for these cases? cc @manuzhang @Ngone51 https://github.com/apache/spark/blob/74aed8cc8b94cb459ff12a6e8f1f15cb7aea8c40/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala#L198-L227
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
