maropu commented on a change in pull request #28239: [SPARK-31467][SQL][TEST]
Refactor the sql tests to prevent TableAlreadyExistsException
URL: https://github.com/apache/spark/pull/28239#discussion_r410864812
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -1236,43 +1273,47 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
ignore("SPARK-10310: " +
"script transformation using default input/output SerDe and record
reader/writer") {
- spark
- .range(5)
- .selectExpr("id AS a", "id AS b")
- .createOrReplaceTempView("test")
+ withTempView("test") {
+ spark
+ .range(5)
+ .selectExpr("id AS a", "id AS b")
+ .createOrReplaceTempView("test")
- val scriptFilePath = getTestResourcePath("data")
- checkAnswer(
- sql(
- s"""FROM(
- | FROM test SELECT TRANSFORM(a, b)
- | USING 'python $scriptFilePath/scripts/test_transform.py "\t"'
- | AS (c STRING, d STRING)
- |) t
- |SELECT c
+ val scriptFilePath = getTestResourcePath("data")
+ checkAnswer(
+ sql(
+ s"""FROM(
+ | FROM test SELECT TRANSFORM(a, b)
+ | USING 'python $scriptFilePath/scripts/test_transform.py "\t"'
+ | AS (c STRING, d STRING)
+ |) t
+ |SELECT c
""".stripMargin),
- (0 until 5).map(i => Row(i + "#")))
+ (0 until 5).map(i => Row(i + "#")))
+ }
}
ignore("SPARK-10310: script transformation using LazySimpleSerDe") {
- spark
- .range(5)
- .selectExpr("id AS a", "id AS b")
- .createOrReplaceTempView("test")
-
- val scriptFilePath = getTestResourcePath("data")
- val df = sql(
- s"""FROM test
- |SELECT TRANSFORM(a, b)
- |ROW FORMAT SERDE 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
- |WITH SERDEPROPERTIES('field.delim' = '|')
- |USING 'python $scriptFilePath/scripts/test_transform.py "|"'
- |AS (c STRING, d STRING)
- |ROW FORMAT SERDE 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
- |WITH SERDEPROPERTIES('field.delim' = '|')
+ withTempView("data") {
Review comment:
`data` -> `test`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
