maropu commented on a change in pull request #28269:
URL: https://github.com/apache/spark/pull/28269#discussion_r411324353



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1280,6 +1280,47 @@ abstract class DynamicPartitionPruningSuiteBase
       )
     }
   }
+
+  test("Use In when partition size not greater than 
optimizerInSetConversionThreshold") {
+    def checkIn(plan: SparkPlan, expect: Boolean): Unit = {
+      val hasIn = collectDynamicPruningExpressions(plan).exists {
+        case e: InSubqueryExec =>
+          e.predicate match {

Review comment:
       Ur, actually `e.predicate.isInstanceOf[In]`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to