HyukjinKwon commented on a change in pull request #28276:
URL: https://github.com/apache/spark/pull/28276#discussion_r411848301
##########
File path: sql/core/src/test/resources/sql-tests/inputs/extract.sql
##########
@@ -83,3 +83,21 @@ select extract(epoch from c) from t;
select extract(not_supported from c) from t;
select extract(not_supported from i) from t;
+
+-- In SPARK-31476, we've supported extract('field', source), too
+select date_part('millennium', c) from t;
Review comment:
Wait .. are `DatePart` and `Extract` the same? If so, it might be better
to have one class and handle aliases via `expression(..., setAlias=true)` at
`FunctionRegistry`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
