HyukjinKwon commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r415658286
##########
File path: R/pkg/R/install.R
##########
@@ -103,12 +103,14 @@ install.spark <- function(hadoopVersion = "2.7",
mirrorUrl = NULL,
# can use dir.exists(packageLocalDir) under R 3.2.0 or later
if (!is.na(file.info(packageLocalDir)$isdir) && !overwrite) {
if (releaseUrl != "") {
- message(paste(packageName, "found, setting SPARK_HOME to",
packageLocalDir))
+ message(gettextf("%s found, setting SPARK_HOME to %s",
+ packageName, packageLocalDir, domain = "R-SparkR"),
+ domain = NA)
} else {
- fmt <- "%s for Hadoop %s found, setting SPARK_HOME to %s"
- msg <- sprintf(fmt, version, ifelse(hadoopVersion == "without", "Free
build", hadoopVersion),
- packageLocalDir)
- message(msg)
+ message(gettextf("%s for Hadoop %s found, setting SPARK_HOME to %s",
Review comment:
ditto
##########
File path: R/pkg/R/install.R
##########
@@ -103,12 +103,14 @@ install.spark <- function(hadoopVersion = "2.7",
mirrorUrl = NULL,
# can use dir.exists(packageLocalDir) under R 3.2.0 or later
if (!is.na(file.info(packageLocalDir)$isdir) && !overwrite) {
if (releaseUrl != "") {
- message(paste(packageName, "found, setting SPARK_HOME to",
packageLocalDir))
+ message(gettextf("%s found, setting SPARK_HOME to %s",
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
