MichaelChirico commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r415687299
##########
File path: R/pkg/R/install.R
##########
@@ -293,7 +289,7 @@ sparkCachePath <- function() {
Sys.getenv("XDG_CACHE_HOME", file.path(Sys.getenv("HOME"), ".cache")),
"spark")
}
} else {
- stop(sprintf("Unknown OS: %s", .Platform$OS.type))
+ stop(gettextf("Unknown OS: %s", .Platform$OS.type, domain = "R-SparkR"),
domain = NA)
Review comment:
Keeping the message as "intact" as possible is also for the benefit of
translators -- an intact message can be completely adapted to different
grammars.
As there is as yet no translation / offer to translate, so this is not a
priority for this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
