Ngone51 commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-619962577
> about the pattern, it should be added but I think each will add what he needed and how he wanted it as it also supports adding local properties starting with MDC. Could you give a pattern configuration template to make MDC work with Spark? IIUC, the configuration is related to the `key` that put in MDC. If you've already hard-coded `key`s (`appId` & `appName`) in the code, how do people add their custom configurations? > about ThreadUtils without all that change the MDC will not propagate to all places only to the scope of that thread and from my tests it is not enough, we are using that code internally for more than a year. So you internally use MDC to track logs at application level? (IIUC, `appId` and `appName` will be prepend to each logs with MDC, right?) But is it possible that more than one applications log in the same file? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
