Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4972#discussion_r26442697 --- Diff: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala --- @@ -200,7 +198,7 @@ private[spark] object SizeEstimator extends Logging { if (length <= ARRAY_SIZE_FOR_SAMPLING) { for (i <- 0 until length) { --- End diff -- while you are doing this, do you mind change the for loop into a while loop? i.e. ```scala var i = 0 while (i < length) { ... i += 1 } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org