maropu commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r416579720
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##########
@@ -48,7 +48,7 @@ private[sql] class DB2ConnectionProvider(driver: Driver,
options: JDBCOptions)
result
}
- override def setAuthenticationConfigIfNeeded(): Unit = {
+ override def setAuthenticationConfigIfNeeded(): Unit =
SecurityConfigurationLock.synchronized {
Review comment:
> That said the newly added security configuration is stacked together
with its parent.
Ah, I see. Thanks for the kind explanation. Could you write some tests for
the sequence? I think its better to check if the sequence is valid in the JVM
implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
