xuanyuanking commented on pull request #28391: URL: https://github.com/apache/spark/pull/28391#issuecomment-620931197
I think the change here is reasonable since the condition changed from `hasNewData` to `hasExecuted` in SPARK-31278. But yes, as @HeartSaVioR mentioned the UT is relevant. Maybe we also need to add new UT in StreamingQueryListenerSuite.scala? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
