igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r419294180
########## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ########## @@ -674,6 +677,22 @@ private[spark] class Executor( } } + private def setMDCForTask(taskDescription: TaskDescription): Unit = { + val properties = taskDescription.properties + + def getProperty(id: String): String = { + Option(properties.getProperty(id)).getOrElse(conf.get(id, "")) + } + + org.slf4j.MDC.put("appId", getProperty("spark.app.id")) + org.slf4j.MDC.put("appName", getProperty("spark.app.name")) Review comment: But when debugging I see that in conf it presently, so why it not being propagated to the task? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org